Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing React for the first example. #14346

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

devrchancay
Copy link
Contributor

Importing react in the example to have consistency in relation to the others.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoeCortopassi
Copy link
Contributor

@devrchancay looks good to me. This just fixes the omission from the first example to make it consistent with the examples directly below it

@devrchancay
Copy link
Contributor Author

@gaearon good to merge for consistency?

@threepointone
Copy link
Contributor

Seems reasonable to me, I'm going to approve/merge this in. Thanks @devrchancay!

@threepointone threepointone merged commit 3f0bcaf into facebook:master Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants